Properly identify camel cased acronyms as UpperCamelCase #6319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Realized that the following doesn't work as expected: #[allow(non_camel_case_types)]
pub struct FOO_BAR;I don't know how long it'll take to fix that, so feel free to merge away. |
Contributor
|
Yeah, that was discussed here: #6130 (comment) TL;DR rust analyzer doesn't currently collect information about attributes applied to items. This is indeed a complex task due to variety of places where The PR itself LGTM. |
Contributor
|
bors r=popzxc |
Contributor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #6305.